Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three updates for HT. #170

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Three updates for HT. #170

merged 3 commits into from
Jan 9, 2020

Conversation

phmarek
Copy link
Contributor

@phmarek phmarek commented Dec 20, 2019

Thank you!

@stassats
Copy link
Member

Does "Respect the "Content-Length" header when parsing form data." still just produces an error?

@stassats
Copy link
Member

create-folder-dispatcher-and-handler is exported, changing from &optional to &key is a no go.

@phmarek
Respect the "Content-Length" header when parsing form data.
acf413a 
That fixes requests with "Content-length: 0" but including
a MIME boundary; Firefox sends that when uploading files that
the user can't read (eg wrong owner); HT hangs waiting on the
MIME boundaries, although the C-l should implicicate there
won't be any.
@phmarek
New function SSL-GET-PEER-CERTIFICATE.
0613153
@phmarek
Have a callback for static file handlers.
6c0d51e 
My usecase is to provide some caching headers by passing this
callback:

    (lambda (path content-type)
      (declare (ignore path content-type))
      (setf (hunchentoot:header-out "Cache-Control")
            "max-age=864000"))

Sadly there've been &optional args; so, to avoid mixing &optional and
&key args new function names are required.
@stassats
Copy link
Member

So what happens with Content-length: 0? Does it still work?

@stassats
Copy link
Member

Compared to #164

@stassats
Copy link
Member

stassats commented Jan 9, 2020

So?

@phmarek
Copy link
Contributor Author

phmarek commented Jan 9, 2020

Sorry about the delay. I haven't forgotten, I just don't find a large enough block of time to concentrate on that.
I'm running that code in my setup, and even the "Content-length: 0" requests from Firefox are correctly handled (no hang, no error, just no file contents being seen by the hunchentoot handler); but I wanted to do some more manual tests, and perhaps even drop some automated tests in.

@stassats stassats merged commit 585b45b into edicl:master Jan 9, 2020
@phmarek
Copy link
Contributor Author

phmarek commented Jan 9, 2020

Oh, thanks a lot!

@phmarek phmarek mentioned this pull request Jan 9, 2020
Closed
@phmarek phmarek deleted the pr branch January 14, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phmarek @stassats